RE: [PATCH 15/18] staging: fsl-dpaa2/eth: Reorder priv fields

[Ruxandra Ioana Radulescu]

> -----Original Message-----
> From: Greg KH [mailto:gregkh@xxxxxxxxxxxxxxxxxxx]
> Sent: Tuesday, June 13, 2017 1:04 PM
> To: Ruxandra Ioana Radulescu <ruxandra.radulescu@xxxxxxx>
> Cc: devel@xxxxxxxxxxxxxxxxxxxx; stuyoder@xxxxxxxxx; arnd@xxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx; agraf@xxxxxxx; Bharat Bhushan
> <bharat.bhushan@xxxxxxx>; Bogdan Purcareata
> <bogdan.purcareata@xxxxxxx>; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx;
> Laurentiu Tudor <laurentiu.tudor@xxxxxxx>
> Subject: Re: [PATCH 15/18] staging: fsl-dpaa2/eth: Reorder priv fields
> 
> On Tue, Jun 06, 2017 at 10:00:38AM -0500, Ioana Radulescu wrote:
> > Reorder fields in the device's private structure such that
> > the ones most used on the hotpath are at the beginning of
> > the structure.
> >
> > This brings a small performance improvement due to better
> > cache usage.
> 
> Really?  What kind of performance improvement?  Always be specific.

Fair point, thanks.

The test scenario was ipfwd with small frames and the improvement ~1%,
but I took this patch from an internal repo, so I need to redo the
measurements on the current tree before resending.

> 
> Please fix up and resend.

We're preparing a larger patchset with several optimizations, I'll
probably include the v2 there.

Thanks,
Ioana