Re: [PATCH v11 5/6] i2c: designware: add SLAVE mode functions

From: Luis Oliveira
Date: Wed Jun 14 2017 - 09:07:35 EST


On 14-Jun-17 13:20, Andy Shevchenko wrote:
> On Wed, Jun 14, 2017 at 1:43 PM, Luis Oliveira
> <Luis.Oliveira@xxxxxxxxxxxx> wrote:
>> - Changes in Kconfig to enable I2C_DESIGNWARE_SLAVE support
>> - Slave functions added to core library file
>> - Slave abort sources added to common source file
>> - New driver: i2c-designware-slave added
>> - Changes in the Makefile to compile the I2C_DESIGNWARE_SLAVE module
>> when supported by the architecture.
>>
>> All the SLAVE flow is added but it is not enabled via platform
>> driver.
>
>> + //~ if (stat & DW_IC_INTR_TX_OVER)
>> + //~ dw_readl(dev, DW_IC_CLR_TX_OVER);
>
> If you are going to ignore reviewers' comments you will delay your
> work to be applied.
>
Im so sorry. I was doing some tests on the irq_handler and used the wrong branch
to create the patchset.
Believe me I've looked for mistakes like this but I've read the code so many
times I don't think I can see the obvious anymore.

> Certainly you are about to miss v4.13.
>