Re: [PATCH v4 2/2] arm64: dts: renesas: salvator-x: Add ADV7482 support

From: Geert Uytterhoeven
Date: Wed Jun 14 2017 - 07:33:58 EST


Hi Kieran,

On Wed, Jun 14, 2017 at 11:43 AM, Kieran Bingham
<kieran.bingham+renesas@xxxxxxxxxxxxxxxx> wrote:
> On 14/06/17 10:39, Geert Uytterhoeven wrote:
>> On Tue, Jun 13, 2017 at 2:35 AM, Kieran Bingham <kbingham@xxxxxxxxxx> wrote:
>>> From: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx>
>>>
>>> Provide ADV7482, and the needed connectors
>>>
>>> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx>
>>
>> Thanks for your patch!
>>
>>> v4:
>>> - dt: Rebase to dts/renesas/salvator-x.dtsi
>>> - dt: Use AIN0-7 rather than AIN1-8
>>>
>>> arch/arm64/boot/dts/renesas/salvator-x.dtsi | 123 +++++++++++++++++++++-
>>
>> I believe all of this applies to both Salvator-X and Salvator-XS?
>>
>> Hence it should be applied to salvator-common.dtsi instead of salvator-x.dtsi.
>
> Hrm ... I don't have a salator-common.dtsi ... I'll need a new rebase.

It's always a good idea to base your Renesas DT patches on Simon's latest
devel branch.

> But it sounds logical :)

Good :-)

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds