Re: [PATCH] fbdev: avoid int-in-bool-context warning

From: Bartlomiej Zolnierkiewicz
Date: Wed Jun 14 2017 - 06:04:49 EST


On Thursday, May 11, 2017 02:47:01 PM Arnd Bergmann wrote:
> gcc-7 suspects this code might be wrong because we use the
> result of a multiplication as a bool:
>
> drivers/video/fbdev/core/fbmon.c: In function 'fb_edid_add_monspecs':
> drivers/video/fbdev/core/fbmon.c:1051:84: error: '*' in boolean context, suggest '&&' instead [-Werror=int-in-bool-context]
>
> It's actually fine, so let's add a comparison to zero to make
> that clear to the compiler too.
>
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Patch queued for 4.12, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics