Re: [PATCH v2 0/2] Avoid namespace collision within macros & tidyup

[Ian Arkver]

On 13/06/17 14:33, Ramesh Shanmugasundaram wrote:
> Hi All,
>
> The readx_poll_timeout & similar macros defines local variable that can
> cause name space collision with the caller. Fixed this issue by prefixing
> them with underscores.

The compound statement has a local variable scope, so these won't 
collide with the caller I believe.

> Also tidied couple of instances where the macro
> arguments are used in expressions without paranthesis.
>
> This patchset is based on top of today's linux-next repo.
> commit bc4c75f41a1c ("Add linux-next specific files for 20170613")
>
> Change history:
>
> v2:
>   - iopoll.h:
> 	- Enclosed timeout_us & sleep_us arguments with paranthesis
>   - regmap.h:
> 	- Enclosed timeout_us & sleep_us arguments with paranthesis
> 	- Renamed pollret to __ret
>
> Note: timeout_us cause spare check warning as identified here [1].
>
> [1] https://www.mail-archive.com/linux-renesas-soc@xxxxxxxxxxxxxxx/msg15138.html
>
> Thanks,
> Ramesh
>
> Ramesh Shanmugasundaram (2):
>    iopoll: Avoid namespace collision within macros & tidyup
>    regmap: Avoid namespace collision within macro & tidyup
>
>   include/linux/iopoll.h | 12 +++++++-----
>   include/linux/regmap.h | 17 +++++++++--------
>   2 files changed, 16 insertions(+), 13 deletions(-)