Re: [PATCH 1/3] arm: dts: mt2701: Add ethernet device node

From: Sean Wang
Date: Tue Jun 13 2017 - 23:08:38 EST


On Fri, 2017-06-09 at 10:22 +0200, Matthias Brugger wrote:
>
> On 01/06/17 08:08, Erin Lo wrote:
> > From: Sean Wang <sean.wang@xxxxxxxxxxxx>
> >
> > Add ethernet device node for MT2701
> >
> > Signed-off-by: Sean Wang <sean.wang@xxxxxxxxxxxx>
> > Signed-off-by: Erin Lo <erin.lo@xxxxxxxxxxxx>
> > ---
> > arch/arm/boot/dts/mt2701.dtsi | 20 ++++++++++++++++++++
> > 1 file changed, 20 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/mt2701.dtsi b/arch/arm/boot/dts/mt2701.dtsi
> > index 8037210..de88bd7 100644
> > --- a/arch/arm/boot/dts/mt2701.dtsi
> > +++ b/arch/arm/boot/dts/mt2701.dtsi
> > @@ -420,6 +420,26 @@
> > #clock-cells = <1>;
> > };
> >
> > + eth: ethernet@1b100000 {
> > + compatible = "mediatek,mt2701-eth", "syscon";
> > + reg = <0 0x1b100000 0 0x20000>;
> > + interrupts = <GIC_SPI 200 IRQ_TYPE_LEVEL_LOW>,
> > + <GIC_SPI 199 IRQ_TYPE_LEVEL_LOW>,
> > + <GIC_SPI 198 IRQ_TYPE_LEVEL_LOW>;
> > + clocks = <&topckgen CLK_TOP_ETHIF_SEL>,
> > + <&ethsys CLK_ETHSYS_ESW>,
> > + <&ethsys CLK_ETHSYS_GP1>,
> > + <&ethsys CLK_ETHSYS_GP2>,
> > + <&apmixedsys CLK_APMIXED_TRGPLL>;
> > + clock-names = "ethif", "esw", "gp1", "gp2", "trgpll";
> > + power-domains = <&scpsys MT2701_POWER_DOMAIN_ETH>;
> > + mediatek,ethsys = <&ethsys>;
> > + mediatek,pctl = <&syscfg_pctl_a>;
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + status = "disabled";
> > + };
> > +
>
> I'm missing the reset properties.


Hi Matthias,

Appreciate your careful reviewing,

I'll add it for the missing which causes binding violation.


Sean

>
> Regards,
> Matthias