Re: [PATCH v2] clockevents/tcb_clksrc: implement suspend/resume

From: Alexandre Belloni
Date: Tue Jun 13 2017 - 08:28:06 EST


On 13/06/2017 at 14:21:10 +0200, Daniel Lezcano wrote:
> On 12/05/2017 20:22, Alexandre Belloni wrote:
> > On sama5d2, power to the core may be cut while entering suspend mode. It is
> > necessary to save and restore the TCB registers.
> >
> > Signed-off-by: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxxxxxxxxx>
>
> The context will be saved/restored on all the platforms (other than
> sama5d2) using this timer even if the clock is not powered down. Is that ok?
>

Yes, that is fine. There is not much we can do here until we can
determine what is the target suspend state from the drivers.

> Should it be tagged for stable@?
>

No because support for this suspend mode is not yet upstream.

> Side note: the config option is in drivers/misc, any particular reason
> to have it there and not in the clocksource's Kconfig?
>

Mostly historical, this is changed in the other series.


--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com