Re: [PATCH] regulator: core: Prioritise consumer mappings over regulator name

From: Mark Brown
Date: Tue Jun 13 2017 - 06:16:15 EST


On Tue, Jun 13, 2017 at 09:07:31AM +0100, Charles Keepax wrote:
> On Mon, Jun 12, 2017 at 05:38:56PM +0100, Mark Brown wrote:
> > On Mon, Jun 12, 2017 at 04:17:52PM +0100, Charles Keepax wrote:

> > > r = regulator_lookup_by_name(supply);
> > > - if (r)
> > > - return r;

> > Why have you left the lookup here?

> Yeah was thinking that could maybe use a comment, if we don't
> find a match in the following loop over the supply map then we
> will exit with the regulator found here. So we can still use the
> regulator name for lookup just we default to the supply map.

Why are we even doing the lookup here if we only use it if we fail to
find a supply mapping?

Attachment: signature.asc
Description: PGP signature