Re: [PATCH 2/2] ARM: cpuidle: Support asymmetric idle definition

From: Sudeep Holla
Date: Tue Jun 13 2017 - 05:46:12 EST


Hi Daniel,

On 12/06/17 16:55, Daniel Lezcano wrote:
> Some hardware have clusters with different idle states. The current code does
> not support this and fails as it expects all the idle states to be identical.
>
> Because of this, the Mediatek mtk8173 had to create the same idle state for a
> big.Little system and now the Hisilicon 960 is facing the same situation.
>
> Solve this by simply assuming the multiple driver will be needed for all the
> platforms using the ARM generic cpuidle driver which makes sense because of the
> different topologies we can support with a single kernel for ARM32 or ARM64.
>
> Every CPU has its own driver, so every single CPU can specify in the DT the
> idle states.
>
> This simple approach allows to support the future dynamIQ system, current SMP
> and HMP.
>
> Tested on:
> - 96boards: Hikey 620
> - 96boards: Hikey 960
> - 96boards: dragonboard410c
> - Mediatek 8173
>
> Cc: Sudeep Holla <sudeep.holla@xxxxxxx>

Sorry for the delay, as I mentioned earlier I would like to add the
minimum change to avoid this on platforms that don't require this. But
that can be done later, I will try to come up with simple solution when
I get time. Though I am not 100% happy ;), I am fine with this change
for now:

Acked-by: Sudeep Holla <sudeep.holla@xxxxxxx>

--
Regards,
Sudeep