Re: [PATCH] rts5208: Fix a sleep-in-atomic bug in sd_send_cmd_get_rsp

From: Greg KH
Date: Tue Jun 13 2017 - 05:42:16 EST


On Mon, Jun 05, 2017 at 09:31:36AM +0800, Jia-Ju Bai wrote:
> The driver may sleep under a spin lock, and the function call path is:
> rtsx_exclusive_enter_ss (acquire the lock by spin_lock)
> rtsx_enter_ss
> rtsx_power_off_card
> sd_cleanup_work
> sd_stop_seq_mode
> sd_switch_clock
> sd_ddr_tuning
> sd_ddr_pre_tuning_tx
> sd_send_cmd_get_rsp
> wait_timeout
> schedule_timeout --> may sleep
>
> To fix it, "wait_timeout" is replaced with mdelay in sd_send_cmd_get_rsp.
>
> Signed-off-by: Jia-Ju Bai <baijiaju1990@xxxxxxx>
> ---
> drivers/staging/rts5208/sd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

You sent 3 copies of this patch, and I have no idea which to take.
Please fix up and resend the _one_ that is correct.

thanks,

greg k-h