Re: [PATCH 15/16] tty: serdev: use dev_groups and not dev_attrs for bus_type

[Greg Kroah-Hartman]

On Sat, Jun 10, 2017 at 10:01:22AM +1000, Stephen Rothwell wrote:
> Hi Greg,
> 
> On Sat, 10 Jun 2017 09:56:49 +1000 Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote:
> >
> > > +static struct attribute *serdev_device_attrs[] = {  
> >                             ^^^^^^^^^^^^^^^^^^^
> > Should have been "serdev_device_groups"
> 
> Sorry, my mistake.
> 
> > > +	&dev_attr_modalias.attr,
> > > +	NULL,
> > >  };
> > > +ATTRIBUTE_GROUPS(serdev_device);
> 
> I really hate macros that create symbols by concatenating parts. :-(

I totally agree, but it's the only way I could come up with at the time
to make this type of macro to simplify a lot of boiler-plate code.

sorry,

greg k-h