Re: [PATCH -v4 0/14] mm: make movable onlining suck less

[Michal Hocko]

On Fri 09-06-17 17:51:24, Wei Yang wrote:
> Hi, Michal
> 
> I am not that familiar with hotplug and trying to catch up the issue
>  and your solution.
> 
> One potential issue I found is we don't check the physical boundary
> when add_memory_resource().
> 
> For example, on x86-64, only 64T physical memory is supported currently.
> Looks it is expanded after 5-level pagetable is introduced. While there is
> still some limitations on this. But we don't check the boundary I think.
> 
> During the bootup, this is ensured by the max_pfn which is guaranteed to
> be under MAX_ARCH_PFN. I don't see some limitation on this when doing
>  hotplug.

This might be true and I would have to double check but this rework
doesn't change anything in that regards. Or do I miss something?
-- 
Michal Hocko
SUSE Labs