Re: [PATCH 10/11] s390: drivers: convert to use DRIVER_ATTR_RO/WO

From: Greg Kroah-Hartman
Date: Fri Jun 09 2017 - 06:20:54 EST


On Fri, Jun 09, 2017 at 12:11:41PM +0200, Heiko Carstens wrote:
> On Fri, Jun 09, 2017 at 11:03:13AM +0200, Greg Kroah-Hartman wrote:
> > We are trying to get rid of DRIVER_ATTR(), and the s390 drivers'
> > attributes can be trivially changed to use DRIVER_ATTR_RO() and
> > DRIVER_ATTR_WO().
> >
> > Cc: Martin Schwidefsky <schwidefsky@xxxxxxxxxx>
> > Cc: Heiko Carstens <heiko.carstens@xxxxxxxxxx>
> > Cc: Julian Wiedmann <jwi@xxxxxxxxxxxxxxxxxx>
> > Cc: Ursula Braun <ubraun@xxxxxxxxxxxxxxxxxx>
> > Cc: Peter Oberparleiter <oberpar@xxxxxxxxxxxxxxxxxx>
> > Cc: Gerald Schaefer <gerald.schaefer@xxxxxxxxxx>
> > Cc: <linux-s390@xxxxxxxxxxxxxxx>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> > ---
> > drivers/s390/char/sclp.c | 12 ++++++------
> > drivers/s390/char/vmlogrdr.c | 7 ++-----
> > drivers/s390/net/ctcm_main.c | 6 +++---
> > drivers/s390/net/lcs.c | 6 +++---
> > drivers/s390/net/netiucv.c | 14 ++++++--------
> > drivers/s390/net/qeth_core_main.c | 6 +++---
> > 6 files changed, 23 insertions(+), 28 deletions(-)
>
> I assume this will go upstream via your tree.

Yup, I can take it.

> Acked-by: Heiko Carstens <heiko.carstens@xxxxxxxxxx>

Thanks for the review!

greg k-h