Re: [RFC PATCH 1/3] Add sysfs based cpuinfo structure.

From: Greg KH
Date: Thu Jun 08 2017 - 14:27:06 EST


On Thu, Jun 08, 2017 at 06:56:13PM +0200, Felix Schnizlein wrote:
> Create a new sysfs attribute group called 'cpuinfo' for each
> online cpu. The cleaned up cpuinfo shows up in a sysfs
> subdirectory here: /sys/devices/system/cpu/cpu*/cpuinfo.
>
> Define preprocessor macros (CPUINFO_DEFINE_* and CPUINFO_ATTR) to make
> defining new sysfs attributes for cpuinfo more easy.
>
> Signed-off-by: Thomas Renninger <trenn@xxxxxxxx>
> ---
> drivers/base/Kconfig | 7 ++++++
> drivers/base/Makefile | 1 +
> drivers/base/cpuinfo.c | 57 ++++++++++++++++++++++++++++++++++++++++++++++
> include/linux/cpuhotplug.h | 1 +
> include/linux/cpuinfo.h | 47 ++++++++++++++++++++++++++++++++++++++
> 5 files changed, 113 insertions(+)
> create mode 100644 drivers/base/cpuinfo.c
> create mode 100644 include/linux/cpuinfo.h
>
> diff --git a/drivers/base/Kconfig b/drivers/base/Kconfig
> index d718ae4..7900e31 100644
> --- a/drivers/base/Kconfig
> +++ b/drivers/base/Kconfig
> @@ -224,6 +224,13 @@ config DEBUG_TEST_DRIVER_REMOVE
> unusable. You should say N here unless you are explicitly looking to
> test this functionality.
>
> +config CPUINFO_SYSFS
> + bool "Enable sysfs based cpuinfo"
> + depends on SYSFS && X86
> + default y
> + help
> + This option enables cpuinfo in sysfs.

Why would you not want this? Why make it an option at all?