Re: [PATCH v6 05/10] nvmet: implement namespace identify descriptor list

[Johannes Thumshirn]

On 06/08/2017 09:44 AM, Christoph Hellwig wrote:
>> +	if (sg_zeroout_area(req->sg, req->sg_cnt, NVME_IDENTIFY_DATA_SIZE, off)
> 
> Shouldn;t the third argument be NVME_IDENTIFY_DATA_SIZE - off in theory?
> It's probably fine as is as the S/G helpers deal with overflows
> gracefully, but still..

Ahm yes. *doh*

Can you fix it up when applying?

-- 
Johannes Thumshirn                                          Storage
jthumshirn@xxxxxxx                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 NÃrnberg
GF: Felix ImendÃrffer, Jane Smithard, Graham Norton
HRB 21284 (AG NÃrnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850