Re: [PATCH v6 01/10] scatterlist: add sg_zeroout_area() helper
From: Christoph Hellwig
Date: Thu Jun 08 2017 - 03:41:30 EST
> size_t sg_pcopy_to_buffer(struct scatterlist *sgl, unsigned int nents,
> void *buf, size_t buflen, off_t skip);
>
> +size_t sg_zeroout_area(struct scatterlist *sgl, unsigned int nents,
> + size_t buflen, off_t skip);
Maybe sg_zero_buffer to fit with the other functions in the family?
(I'd be happy to fix this up if you're ok and we don't need another
respin otherwise).
> + while ((offset < buflen) && sg_miter_next(&miter)) {
Nit: no need for the inner braces.
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@xxxxxx>