Re: [PATCH 1/3] staging: typec: Fix one defect of incorrect type in argument.

From: Dan Carpenter
Date: Thu Jun 01 2017 - 10:58:19 EST


On Thu, Jun 01, 2017 at 07:21:00AM +0000, ? ? wrote:
> From: Pan Li <incarnation.p.lee@xxxxxxxxxxx>
>
> Convert type le16 to cpu of argument 1 in function pd_header_cnt.
>
> Signed-off-by: Pan Li <incarnation.p.lee@xxxxxxxxxxx>
> ---
> drivers/staging/typec/tcpci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/typec/tcpci.c b/drivers/staging/typec/tcpci.c
> index df72d8b..405c9cc 100644
> --- a/drivers/staging/typec/tcpci.c
> +++ b/drivers/staging/typec/tcpci.c
> @@ -287,7 +287,7 @@ static int tcpci_pd_transmit(struct tcpc_dev *tcpc,
> unsigned int reg, cnt, header;
> int ret;
>
> - cnt = msg ? pd_header_cnt(msg->header) * 4 : 0;
> + cnt = msg ? pd_header_cnt(le16_to_cpu(msg->header)) * 4 : 0;

I guess this one is probably correct...

regards,
dan carpenter