Re: [PATCH 1/7] powerpc/mm: rename map_page() to map_kernel_page() on PPC32

From: Christophe LEROY
Date: Tue May 30 2017 - 08:47:04 EST




Le 30/05/2017 Ã 12:50, Michael Ellerman a Ãcrit :
Christophe Leroy <christophe.leroy@xxxxxx> writes:

...

Please tell me why.

Because of patch https://patchwork.ozlabs.org/patch/766777/ which modifies patch_instruction() to use an alternative mapping.
Compilation fails on PPC32 because map_kernel_page() only exists on PPC64. However we have map_page() which does the same on PPC32, hence the renaming.


You also moved the declaration from mmu_decl.h to book3s/32/pgtable.h,
but didn't update any includes, presumably we're confident everything
gets pgtable.h somehow?

Yes I did that so that lib/code_patching.c sees it.
All users of map_page() already include pgtable in a way or another.

Christophe