Re: [PATCH 11/15] mfd: palmas: use devm_of_platform_populate()

[Lee Jones]

On Mon, 29 May 2017, Benjamin Gaignard wrote:

> Use devm_of_platform_populate() to be sure that of_platform_depopulate
> is called when removing the driver.
> 
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@xxxxxxxxxx>
> 
> CC: Tony Lindgren <tony@xxxxxxxxxxx>
> CC: Lee Jones <lee.jones@xxxxxxxxxx>
> CC: linux-kernel@xxxxxxxxxxxxxxx
> ---
>  drivers/mfd/palmas.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

> diff --git a/drivers/mfd/palmas.c b/drivers/mfd/palmas.c
> index 9103aff..3922a93 100644
> --- a/drivers/mfd/palmas.c
> +++ b/drivers/mfd/palmas.c
> @@ -676,7 +676,7 @@ static int palmas_i2c_probe(struct i2c_client *i2c,
>  	 * otherwise continue and add devices using mfd helpers.
>  	 */
>  	if (node) {
> -		ret = of_platform_populate(node, NULL, NULL, &i2c->dev);
> +		ret = devm_of_platform_populate(&i2c->dev);
>  		if (ret < 0) {
>  			goto err_irq;
>  		} else if (pdata->pm_off && !pm_power_off) {

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog