[PATCH] PHY: Exynos: fix I2C dependency for Exynos5250 SATA

From: Arnd Bergmann
Date: Tue May 30 2017 - 05:29:28 EST


Device drivers should not 'select' other subsystems, but rather use
'depends on', to avoid Kconfig dependency loops. This one even
selects a particular I2C host driver for no reason, so we can
remove the select of that particular driver, and turn the I2C
'select' into 'depends on'.

Fixes: bcff4cba41bc ("PHY: Exynos: Add Exynos5250 SATA PHY driver")
Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
---
drivers/phy/samsung/Kconfig | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/phy/samsung/Kconfig b/drivers/phy/samsung/Kconfig
index b7e0645a7bd9..76475b01780d 100644
--- a/drivers/phy/samsung/Kconfig
+++ b/drivers/phy/samsung/Kconfig
@@ -83,10 +83,9 @@ config PHY_EXYNOS5250_SATA
tristate "Exynos5250 Sata SerDes/PHY driver"
depends on SOC_EXYNOS5250
depends on HAS_IOMEM
+ depends on I2C
depends on OF
select GENERIC_PHY
- select I2C
- select I2C_S3C2410
select MFD_SYSCON
help
Enable this to support SATA SerDes/Phy found on Samsung's
--
2.9.0