Re: [PATCH] powerpc: sysdev: simple_gpio: fix Oops in gpio save_regs function

From: Linus Walleij
Date: Mon May 29 2017 - 05:37:54 EST


On Wed, May 24, 2017 at 10:01 AM, Christophe Leroy
<christophe.leroy@xxxxxx> wrote:

> of_mm_gpiochip_add_data() generates an Oops for NULL pointer dereference.
>
> of_mm_gpiochip_add_data() calls mm_gc->save_regs() before
> setting the data, therefore ->save_regs() cannot use gpiochip_get_data()
>
> Fixes: 937daafca774b ("powerpc: simple-gpio: use gpiochip data pointer")
> Cc: stable@xxxxxxxxxxxxxxx
>
> Signed-off-by: Christophe Leroy <christophe.leroy@xxxxxx>

Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Sorry for any screwups I've caused...

Yours,
Linus Walleij