Re: [PATCH 2/3] x86/mce/AMD: Define a list_head for threshold blocks outside the list

From: Borislav Petkov
Date: Sun May 28 2017 - 13:23:00 EST


On Wed, May 24, 2017 at 03:41:46PM -0500, Yazen Ghannam wrote:
> From: Yazen Ghannam <yazen.ghannam@xxxxxxx>
>
> There needs to be a list_head outside of a linked list in order to iterate
> over it and have access to all its elements. This is because the
> list_for_each* macros iterate starting from head->next rather than head.
>
> Define a list_head for the threshold blocks list in struct threshold_bank

struct threshold_block {

...

struct list_head miscj; /*
* List of threshold blocks
* within a bank.
*/

There's your list_head right there.

--
Regards/Gruss,
Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.