Re: [PATCH] x86/timers: Move simple_udelay_calibration past init_hypervisor_platform

From: Andy Shevchenko
Date: Fri May 26 2017 - 21:19:42 EST


+Cc Mathias

On Wed, May 24, 2017 at 9:04 PM, Jan Kiszka <jan.kiszka@xxxxxxxxxxx> wrote:
> This ensures that adjustments to x86_platform done by the hypervisor
> setup is already respected by this simple calibration.
>
> The current user of this, introduced by 1b5aeebf3a92 ("x86/earlyprintk:
> Add support for earlyprintk via USB3 debug port"), comes much later
> into play.
>

Can you elaborate a bit what is the issue you are experience?

> Signed-off-by: Jan Kiszka <jan.kiszka@xxxxxxxxxxx>
> ---
> arch/x86/kernel/setup.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
> index 0b4d3c686b1e..f81823695014 100644
> --- a/arch/x86/kernel/setup.c
> +++ b/arch/x86/kernel/setup.c
> @@ -980,8 +980,6 @@ void __init setup_arch(char **cmdline_p)
> */
> x86_configure_nx();
>
> - simple_udelay_calibration();
> -
> parse_early_param();
>
> #ifdef CONFIG_MEMORY_HOTPLUG
> @@ -1041,6 +1039,8 @@ void __init setup_arch(char **cmdline_p)
> */
> init_hypervisor_platform();
>
> + simple_udelay_calibration();
> +
> x86_init.resources.probe_roms();
>
> /* after parse_early_param, so could debug it */



--
With Best Regards,
Andy Shevchenko