Re: [PATCH v2 13/13] perf tools: add feature header record to pipe-mode

From: Jiri Olsa
Date: Thu May 25 2017 - 04:10:17 EST


On Tue, May 23, 2017 at 12:48:53AM -0700, David Carrillo-Cisneros wrote:

SNIP

> };
>
> @@ -488,6 +489,12 @@ struct time_conv_event {
> u64 time_zero;
> };
>
> +struct feature_event {
> + struct perf_event_header header;
> + u64 header_id;
> + char data[]; /* size bytes of raw data specific to the feature */
> +};

please align the members, like it's in structs around

struct feature_event {
struct perf_event_header header;
u64 header_id;
char data[];
}

thanks,
jirka