Re: [PATCH 2/7] RISC-V: arch/riscv Makefile and Kconfigs

From: Palmer Dabbelt
Date: Wed May 24 2017 - 21:59:35 EST


On Tue, 23 May 2017 03:51:24 PDT (-0700), geert@xxxxxxxxxxxxxx wrote:
> Hi Palmer,
>
> On Tue, May 23, 2017 at 2:41 AM, Palmer Dabbelt <palmer@xxxxxxxxxxx> wrote:
>> --- /dev/null
>> +++ b/arch/riscv/Kconfig
>> @@ -0,0 +1,300 @@
>
>> +config PLIC
>> + bool "Platform-Level Interrupt Controller"
>> + default y
>> + help
>> + This enables support for the PLIC chip found in standard RISC-V
>> + systems. The PLIC is the top-most interrupt controller found in
>> + the system, connected directly to the core complex. All other
>> + interrupt sources (MSI, GPIO, etc) are subordinate to the PLIC.
>> +
>> + If you don't know what to do here, say Y.
>> +
>
> I think this symbol belongs in drivers/irqchip/Kconfig, and the corresponding
> driver in drivers/irqchip/.

OK, makes sense.

https://github.com/riscv/riscv-linux/commit/81e5c9e581c318ea99192d5c1aaf97c197e79272

I'll batch this up with all the other code review comments for a v2.