Re: [PATCH v4 1/4] can: m_can: move Message RAM initialization to function

From: Oliver Hartkopp
Date: Mon May 15 2017 - 23:51:58 EST




On 05/15/2017 06:50 AM, Marc Kleine-Budde wrote:
On 05/12/2017 08:37 AM, Quentin Schulz wrote:
Hi all,

On 05/05/2017 15:50, Quentin Schulz wrote:
To avoid possible ECC/parity checksum errors when reading an
uninitialized buffer, the entire Message RAM is initialized when probing
the driver. This initialization is done in the same function reading the
Device Tree properties.

This patch moves the RAM initialization to a separate function so it can
be called separately from device initialization from Device Tree.

Signed-off-by: Quentin Schulz <quentin.schulz@xxxxxxxxxxxxxxxxxx>

It's been a week since I sent this patch series. Any comments?

Looks good, added to linux-can-next.

Isn't this a fix for linux-can instead?

At least it would make no sense to me to have the upgraded M_CAN driver in Linux 4.12 without this fix.

Regards,
Oliver