Re: [PATCH 17/17] fs: switch ->s_uuid to uuid_t

From: Amir Goldstein
Date: Mon May 15 2017 - 15:38:38 EST


On Mon, May 15, 2017 at 6:43 PM, Christoph Hellwig <hch@xxxxxx> wrote:
> For some file systems we still memcpy into it, but in various places this
> already allows us to use the proper uuid helpers. More to come..
>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> ---

> --- a/fs/xfs/xfs_mount.c
> +++ b/fs/xfs/xfs_mount.c
> @@ -75,7 +75,7 @@ xfs_uuid_mount(
>
> /* Publish UUID in struct super_block */
> BUILD_BUG_ON(sizeof(mp->m_super->s_uuid) != sizeof(uuid_t));

BUILD_BUG_ON not needed anymore now that s_uuid is uuid_t

> - memcpy(&mp->m_super->s_uuid, uuid, sizeof(uuid_t));
> + uuid_copy(&mp->m_super->s_uuid, uuid);