[PATCH 4/6] PNP: Delete an error message for a failed memory allocation in pnp_clone_dependent_set()

From: SF Markus Elfring
Date: Mon May 15 2017 - 15:18:50 EST


From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
Date: Mon, 15 May 2017 20:00:38 +0200

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
---
drivers/pnp/quirks.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/pnp/quirks.c b/drivers/pnp/quirks.c
index 215a50723243..34e2d4563bbd 100644
--- a/drivers/pnp/quirks.c
+++ b/drivers/pnp/quirks.c
@@ -159,8 +159,5 @@ static struct pnp_option *pnp_clone_dependent_set(struct pnp_dev *dev,
- if (!new_option) {
- dev_err(&dev->dev, "couldn't clone dependent "
- "set %d\n", set);
+ if (!new_option)
return NULL;
- }

*new_option = *option;
new_option->flags = flags;
--
2.13.0