Re: [PATCH] perf report: fix off-by-one for non-activation frames

From: Milian Wolff
Date: Mon May 15 2017 - 11:13:22 EST


On Monday, May 15, 2017 5:04:44 PM CEST Milian Wolff wrote:
> As the documentation for dwfl_frame_pc says, frames that
> are no activation frames need to have their program counter
> decremented by one to properly find the function of the caller.

Note that this leaves the perf build against libunwind in the current, broken
state. I do not know how to detect the activation property there. Does anyone
else? See elfutils source code for what it is doing:

https://sourceware.org/git/?p=elfutils.git;a=blob;f=libdwfl/
dwfl_frame_pc.c;h=296c815b9c73f42d79ac1778d2a0c420b89ee4eb;hb=HEAD

Cheers
--
Milian Wolff | milian.wolff@xxxxxxxx | Software Engineer
KDAB (Deutschland) GmbH&Co KG, a KDAB Group company
Tel: +49-30-521325470
KDAB - The Qt Experts

Attachment: smime.p7s
Description: S/MIME cryptographic signature