[PATCH 1/2] ipack: Delete an error message for a failed memory allocation in ipack_device_read_id()

From: Samuel Iglesias GonsÃlvez
Date: Mon May 15 2017 - 05:08:45 EST


From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
Acked-by: Samuel Iglesias GonsÃlvez <siglesias@xxxxxxxxxx>
---

Greg, Would you mind picking this patch series through your char-misc tree?

Sam

drivers/ipack/ipack.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/ipack/ipack.c b/drivers/ipack/ipack.c
index 12102448fddd..575c4f29e0f7 100644
--- a/drivers/ipack/ipack.c
+++ b/drivers/ipack/ipack.c
@@ -402,7 +402,6 @@ static int ipack_device_read_id(struct ipack_device *dev)
* ID ROM contents */
dev->id = kmalloc(dev->id_avail, GFP_KERNEL);
if (!dev->id) {
- dev_err(&dev->dev, "dev->id alloc failed.\n");
ret = -ENOMEM;
goto out;
}
--
2.11.0