Re: [PATCH] kbuild: add ARM support for tar-pkg

From: Sascha Silbe
Date: Sun May 14 2017 - 12:54:54 EST


Dear Masahiro (is that right?),

Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx> writes:

> 2017-05-13 20:31 GMT+09:00 Sascha Silbe <x-linux@xxxxxxxxxxxxxx>:
>> The fallback code for "unknown" architectures doesn't work on ARM
>> because for ARM (and a couple of other architectures) KBUILD_IMAGE
>> contains only the file name, not the full path. Having an explicit
>> rule also avoids printing the warning for unknown architectures.
>>
>> Signed-off-by: Sascha Silbe <x-linux@xxxxxxxxxxxxxx>
>> ---
>
> Now KBUILD_IMAGE contains the full path for all architectures.
>
>
> Please check the following commit.
>
> commit 152e6744ebfc8fa6cc9fff4ba36271f5f1ba2821
> Author: Michal Marek <mmarek@xxxxxxxx>
> Date: Tue Nov 22 22:34:30 2016 +0100
>
> arm: Use full path in KBUILD_IMAGE definition

Figures. I'm sitting on this patch for years and when I finally get
around to write a commit message, somebody fixed it elsewhere and that
patch went in just a few days ago. :)

The second part of the rationale (getting rid of the warning) still
applies, so I'll follow up with a v2.

Sascha
--
Softwareentwicklung Sascha Silbe, NiederhofenstraÃe 5/1, 71229 Leonberg
https://se-silbe.de/
USt-IdNr.: DE281696641

Attachment: signature.asc
Description: PGP signature