Re: [PATCH v3 4/6] spi: sh-msiof: Add slave mode support

[Rob Herring]

On Thu, May 04, 2017 at 07:45:49PM +0200, Geert Uytterhoeven wrote:
> From: Hisashi Nakamura <hisashi.nakamura.ak@xxxxxxxxxxx>
> 
> Add slave mode support to the MSIOF driver, in both PIO and DMA mode.
> 
> For now this only supports the transmission of messages with a size
> that is known in advance.
> 
> Signed-off-by: Hisashi Nakamura <hisashi.nakamura.ak@xxxxxxxxxxx>
> Signed-off-by: Hiromitsu Yamasaki <hiromitsu.yamasaki.ym@xxxxxxxxxxx>
> [geert: Timeout handling cleanup, spi core integration, cancellation,
> 	rewording]
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> ---
> v3:
>   - Clear TIF_SIGPENDING when interrupted to fix cancellation,
>   - Extract sh_msiof_wait_for_completion(),
>   - Add #include <linux/sched/signal.h>,
>   - Convert to use spi_alloc_slave(),
> 
> v2:
>   - Document "spi-slave" property in DT bindings,
>   - Use spi_controller_is_slave() helper,
>   - Check for "spi-slave" property instead of "slave" child node,
>   - Replace SPI_MASTER_IS_SLAVE by SPI_CONTROLLER_IS_SLAVE,
>   - Implement cancellation.
> ---
>  Documentation/devicetree/bindings/spi/sh-msiof.txt |   2 +

Acked-by: Rob Herring <robh@xxxxxxxxxx>

>  drivers/spi/spi-sh-msiof.c                         | 121 +++++++++++++++------
>  include/linux/spi/sh_msiof.h                       |   6 +
>  3 files changed, 96 insertions(+), 33 deletions(-)