Re: [PATCH] ata: avoid gcc-7 warning in ata_timing_quantize

From: Tejun Heo
Date: Thu May 11 2017 - 10:52:28 EST


Hello, Arnd.

On Thu, May 11, 2017 at 02:51:25PM +0200, Arnd Bergmann wrote:
> gcc-7 warns about the result of a constant multiplication used as
> a boolean:
>
> drivers/ata/libata-core.c: In function 'ata_timing_quantize':
> drivers/ata/libata-core.c:3164:30: warning: '*' in boolean context, suggest '&&' instead [-Wint-in-bool-context]
>
> This slightly rearranges the macro to simplify the code and avoid
> the warning at the same time.
>
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Heh, that's an interesting new warning. Appied to
libata/for-4.12-fixes.

Thanks.

--
tejun