Re: [PATCH] drm/prime: include device.h

From: Chris Wilson
Date: Wed May 10 2017 - 10:48:18 EST


On Wed, May 10, 2017 at 07:40:01AM -0700, Laura Abbott wrote:
> Explictly add linux/device.h to ensure struct device is defined:
>
> In file included from include/drm/drm_file.h:38:0,
> from drivers/gpu/drm/drm_file.c:38:
> include/drm/drm_prime.h:71:14: warning: 'struct device' declared inside
> parameter list will not be visible outside of this definition or
> declaration
> struct device *attach_dev);

We aren't using it for anything other than an opaque pointer, so a
struct device;
forward decl will suffice?
-Chris

--
Chris Wilson, Intel Open Source Technology Centre