Re: [PATCH] x86/power/64: Use char arrays for asm function names

From: Ingo Molnar
Date: Wed May 10 2017 - 01:50:11 EST



* Rafael J. Wysocki <rjw@xxxxxxxxxxxxx> wrote:

> On Tuesday, May 09, 2017 02:00:51 PM Kees Cook wrote:
> > This switches the hibernate_64.S function names into character arrays
> > to match other areas of the kernel where this is done (e.g., linker
> > scripts). Specifically this fixes a compile-time error noticed by the
> > future CONFIG_FORTIFY_SOURCE routines that complained about PAGE_SIZE
> > being copied out of the "single byte" core_restore_code variable.
> >
> > Additionally drops the "acpi_save_state_mem" exern which does not
> > appear to be used anywhere else in the kernel.
> >
> > Cc: Daniel Micay <danielmicay@xxxxxxxxx>
> > Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>
>
> Acked-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
>
> Or I can queue this up if that's preferred.

LGTM too!

Acked-by: Ingo Molnar <mingo@xxxxxxxxxx>

Thanks,

Ingo