Re: [PATCH] net: wireless: ath: ath10k: remove unnecessary code

From: Kalle Valo
Date: Tue May 09 2017 - 08:20:48 EST


Arend Van Spriel <arend.vanspriel@xxxxxxxxxxxx> writes:

> On 9-5-2017 7:33, Kalle Valo wrote:
>> "Gustavo A. R. Silva" <garsilva@xxxxxxxxxxxxxx> writes:
>>
>>> The name of an array used by itself will always return the array's address.
>>> So these tests will always evaluate as false and therefore the _return_
>>> will never be executed.
>>>
>>> Signed-off-by: Gustavo A. R. Silva <garsilva@xxxxxxxxxxxxxx>
>>
>> I don't understand the commit log, especially what does "The name of an
>> array used by itself" mean?
>
> The array fields in struct wmi_start_scan_arg that are checked here are
> fixed size arrays so they can never be NULL.
>
> Maybe that helps rephrasing this commit message.

Much much better, thanks!

--
Kalle Valo