Re: [PATCH] Fix NR_IRQS printk()

From: Thomas Gleixner
Date: Tue May 09 2017 - 03:08:11 EST


On Wed, 3 May 2017, Vincent Legoll wrote:

> Subject : [PATCH] Fix NR_IRQS printk()

The subject line is missing a subsystem token. Please consult

Documentation/process/submitting-patches.rst

and run 'git log path/to/affected.file' to see how a proper subject line
should look like.

> - Missing some whitespace
> - Tell that the third number is "initcnt" (whatever that is)

Your changelog is telling WHAT the patch is doing, but not WHY and despite
the subject claiming to fix something the changelog lacks any information
about the problem it "fixes".

Aside of that: "(whatever that is)" is not really convincing that you know
what you are doing.

Thanks,

tglx