Re: [PATCH] net: mdio-mux: bcm-iproc: call mdiobus_free() in error path

From: David Miller
Date: Mon May 08 2017 - 18:00:13 EST


From: Jon Mason <jon.mason@xxxxxxxxxxxx>
Date: Mon, 8 May 2017 17:48:35 -0400

> If an error is encountered in mdio_mux_init(), the error path will call
> mdiobus_free(). Since mdiobus_register() has been called prior to
> mdio_mux_init(), the bus->state will not be MDIOBUS_UNREGISTERED. This
> causes a BUG_ON() in mdiobus_free(). To correct this issue, add an
> error path for mdio_mux_init() which calls mdiobus_unregister() prior to
> mdiobus_free().
>
> Signed-off-by: Jon Mason <jon.mason@xxxxxxxxxxxx>
> Fixes: 98bc865a1ec8 ("net: mdio-mux: Add MDIO mux driver for iProc SoCs")

Applied and queued up for -stable.