Re: [PATCH 2/2 v2] char: misc: use octal permissions for the proc entry

From: Andy Shevchenko
Date: Sun Apr 30 2017 - 08:52:15 EST


On Sat, Apr 29, 2017 at 10:05 AM, Martin Kaiser <martin@xxxxxxxxx> wrote:
> Thus wrote Andy Shevchenko (andy.shevchenko@xxxxxxxxx):
>> On Tue, Apr 18, 2017 at 12:11 PM, Martin Kaiser <martin@xxxxxxxxx> wrote:

>> Aren't 0 and 0444 different by meaning?
>
> my undestanding is that proc_create() calls proc_create_data(), where
>
> if ((mode & S_IALLUGO) == 0)
> mode |= S_IRUGO;
>
> sets mode to 0444 when it was 0.

Ah, okay. Fair enough.

--
With Best Regards,
Andy Shevchenko