Re: [PATCH] firmware: google: memconsole: Adapt to new coreboot ring buffer format

[Greg Kroah-Hartman]

On Fri, Apr 28, 2017 at 01:44:45PM -0700, Julius Werner wrote:
>     > -------------------------8<--------------------------------------------
> 
>     That needs to go below the --- line, not above it.
> 
> 
> Really? git am --scissors seems to do the right thing for me this way...

Ah, never used that option before, it's not part of my normal workflow.

> Anyway, it was only an FYI, I'll just leave it out.
>  
> 
>     When you say things like "in addition" and "finally", that implies that
>     the code needs to be broken up into multiple patches.  Rememeber, each
>     patch only should ever do 1 thing.
> 
> 
> Well... all these things are required to make the new format work. But I can
> split them up further if you like. 

Please do, makes it easier to review, right?

thanks,

greg k-h