Re: [PATCH net] net: hns: fix ethtool_get_strings overflow in hns driver

From: David Miller
Date: Fri Apr 28 2017 - 16:11:21 EST


From: Timmy Li <lixiaoping3@xxxxxxxxxx>
Date: Thu, 27 Apr 2017 22:18:16 +0800

> @@ -672,7 +672,7 @@ static void hns_gmac_get_strings(u32 stringset, u8 *data)
>
> static int hns_gmac_get_sset_count(int stringset)
> {
> - if (stringset == ETH_SS_STATS)
> + if ((stringset == ETH_SS_STATS) || (stringset == ETH_SS_PRIV_FLAGS))

Excessive parenthesis, please fix this in your entire patch.

Thank you.