Re: [PATCH v4 3/4] KEYS: Support for inserting a certificate into x86 bzImage

From: Mehmet Kayaalp
Date: Thu Apr 27 2017 - 15:02:53 EST



> On Apr 27, 2017, at 9:54 AM, David Howells <dhowells@xxxxxxxxxx> wrote:
>
> Mehmet Kayaalp <mkayaalp@xxxxxxxxxxxxxxxxxx> wrote:
>
>> + /* TODO: update CRC */
>
> Is this bit missing?

I didn't add it, since I wasn't sure it was still used with secure boot. The CRC
code is implemented in multiple places, but not exposed to the tools/scripts.
Should I make the crc32() in tools/pcmcia/crc32hash.c non-static, maybe?

Mehmet