Re: [PATCH] statx: Kill fd-with-NULL-path support in favour of AT_EMPTY_PATH

From: Michael Kerrisk (man-pages)
Date: Thu Apr 27 2017 - 07:54:27 EST


On 27 April 2017 at 00:03, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
> On Wed, Apr 26, 2017 at 2:15 PM, David Howells <dhowells@xxxxxxxxxx> wrote:
>> [!] NOTE: This breaks UAPI introduced in 4.11-rc1.
>
> Ugh.
>
> I'm, applying this now, so that we don't end up with a released kernel
> that supports the NULL filename thing.
>
> I'm not happy about the timing though. And I hope nobody started using
> statx() outside of tests.

Agreed on the timing. Late review on my part didn't help.

But, also, David's fix is not quite right. I will send a patch.

Cheers,

Michael

--
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/