Re: [PATCH v2 8/8] platform: x86: intel_bxtwc_tmu: remove first level irq unmask

From: Andy Shevchenko
Date: Wed Apr 26 2017 - 11:45:09 EST


On Mon, Apr 24, 2017 at 3:24 PM, Lee Jones <lee.jones@xxxxxxxxxx> wrote:
> On Mon, 24 Apr 2017, Andy Shevchenko wrote:
>
>> On Mon, Apr 24, 2017 at 12:24 PM, Lee Jones <lee.jones@xxxxxxxxxx> wrote:
>> > On Sat, 22 Apr 2017, Andy Shevchenko wrote:
>> >
>> >> On Sat, Apr 22, 2017 at 1:34 AM, sathyanarayanan kuppuswamy
>> >> <sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx> wrote:
>> >>
>> >> > Thanks for brining it up. I was planning to ask either Andy or Lee regarding
>> >> > this issue after all patches in the series are reviewed.
>> >>
>> >> Darren, I'm planning to review this soon.
>> >>
>> >> P.S. We have few series flying around regarding to Intel PMIC(s): my
>> >> for Kconfig naming, Hans' for Crystal Cove (touches Kconfig as well),
>> >> and Sathya's series. I hope Lee can collect them in proper order.
>> >
>> > That could be easier said than done.
>>
>> Some of them are already in your tree, then apply
>> - my Kconfig patch which makes Broxton Whiskey Cove to be built
>> independently of Crystal Cove (I didn't notice that patch in your
>> tree, though some of your mail told it had been applied)
>> - Hans' series regarding CherryTrail Whiskey Cove support (if it has all ACKs)
>> - this series after my review.
>>
>> Does it sound doable?
>
> My Inbox is now empty, so all patches are now either applied or
> waiting further Acks/Actions.

I reviewed the series and found it suitable to apply.
The GPIO Whiskey Cove patch will do a conflict (in GPIO tree is
another patch that adds GPIO IRQ masks in a way by using GENMASK(),
so, we might avoid this doing the same in patch 5 here).

Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>

for entire series.

> I'm pretty certain that this set is not going in before v4.13.

It is now on your side :-)

--
With Best Regards,
Andy Shevchenko