Re: [PATCH v3 2/2] staging: iio: isl29028: move out of staging

From: Jonathan Cameron
Date: Wed Apr 26 2017 - 02:04:22 EST


On 26/04/17 06:49, Joe Perches wrote:
> On Wed, 2017-04-26 at 06:30 +0100, Jonathan Cameron wrote:
>> On 25/04/17 02:34, Brian Masney wrote:
>>> Move ISL29028 ALS / Proximity Sensor out of staging and into mainline.
>>>
>>> Signed-off-by: Brian Masney <masneyb@xxxxxxxxxxxxx>
>
> Hey Brian.
>
> Next time it's better to use git format-patch -M
> to reduce the patch size and show renames.
My fault :) For patches doing a move of an IIO driver
out of staging I've asked that people don't
use -M to encourage people to do a 'big picture' review
before we move them out of staging.

This particular one went pretty smoothly, but in some other
staging move patches it's been a different story!

As Brian has done quite a few of these he is getting pretty
good at it ;)

Jonathan
>
>> Applied to the togreg branch of iio.git
>>
>> Thanks,
>>
>> Jonathan
>>> ---
>>> drivers/iio/light/Kconfig | 10 +
>>> drivers/iio/light/Makefile | 1 +
>>> drivers/iio/light/isl29028.c | 723 +++++++++++++++++++++++++++++++++++
>>> drivers/staging/iio/light/Kconfig | 10 -
>>> drivers/staging/iio/light/Makefile | 1 -
>>> drivers/staging/iio/light/isl29028.c | 723 -----------------------------------
>>> 6 files changed, 734 insertions(+), 734 deletions(-)
>>> create mode 100644 drivers/iio/light/isl29028.c
>>> delete mode 100644 drivers/staging/iio/light/isl29028.c
>
> [quoted the entire patch]
>
> And Jonathan, please trim your replies a bit more.
>
> Thanks.
>