Re: [PATCH v3 3/4] zram: make deduplication feature optional

[Joonsoo Kim]

2017-04-25 19:24 GMT+09:00 Sergey Senozhatsky
<sergey.senozhatsky.work@xxxxxxxxx>:
> Hello,
>
> On (04/21/17 10:14), js1304@xxxxxxxxx wrote:
> [..]
>>  int zram_dedup_init(struct zram *zram, size_t num_pages);
>>  void zram_dedup_fini(struct zram *zram);
>> +#else
>> +
>> +static inline u64 zram_dedup_dup_size(struct zram *zram) { return 0; }
>> +static inline u64 zram_dedup_meta_size(struct zram *zram) { return 0; }
>> +
>> +static inline void zram_dedup_insert(struct zram *zram, struct zram_entry *new,
>> +                     u32 checksum) { }
>> +static inline struct zram_entry *zram_dedup_find(struct zram *zram,
>> +                     struct page *page, u32 *checksum) { return NULL; }
>> +
>> +static inline void zram_dedup_init_entry(struct zram *zram,
>> +                     struct zram_entry *entry, unsigned long handle,
>> +                     unsigned int len) { }
>> +static inline bool zram_dedup_put_entry(struct zram *zram,
>> +                     struct zram_entry *entry) { return true; }
>> +
>> +static inline int zram_dedup_init(struct zram *zram,
>> +                     size_t num_pages) { return 0; }
>> +static inline void zram_dedup_fini(struct zram *zram) { }
>> +
>> +#endif
>
> doesn't compile on CONFIG_ZRAM=m config.

Hello,

Good catch!
I fixed it and sent update version, v4.

Thanks.