Re: [PATCH] staging: ks7010: fix few checkpatch warnings in ks_wlan_net.c

From: Greg Kroah-Hartman
Date: Tue Apr 25 2017 - 15:10:38 EST


On Tue, Apr 25, 2017 at 09:02:48PM +0200, Ilia Sergachev wrote:
> Fixes few warnings and checks in drivers/staging/ks7010/ks_wlan_net.c

What type of warnings? What checks? It builds just fine for me here.

You need to be very specific.

And only do one type of thing per patch, a big "fixes all types of
warnings" is not ok in a single patch.

>
> Signed-off-by: Ilia Sergachev <BM-2cVwRgNYPK72fLRfbWfkkmYLu7qHhYpwtr@xxxxxxxxxxxxx>
> Cc: devel@xxxxxxxxxxxxxxxxxxxx,linux-kernel@xxxxxxxxxxxxxxx

That last line doesn't make much sense, does it?

thanks,

greg k-h