Re: [PATCH 20/22] tools arch: Sync arch/x86/lib/memcpy_64.S with the kernel

From: Joe Perches
Date: Tue Apr 25 2017 - 12:28:35 EST


On Tue, 2017-04-25 at 16:18 +0000, Luck, Tony wrote:
> > > If we are going to have all these copies of kernel files below
> > > "tools/...", perhaps checkpatch could warn people touching one
> > > that the other needs the same update?
> >
> > How would checkpatch know tools hasn't already updated the other?
>
> If checkpatch had a list of all the tools copies, it could warn if a patch
> touched a file without touching the copy.

I rather doubt these files are modified simultaneously.

A quick and no doubt incomplete git log -- "tools/*/kernel.h"
seems to show little simultaneity.

> Not completely ideal because people might update the two files in
> separate patches in a series (in which case they would see warnings
> from both patches).
>
> Also means that checkpatch needs the list of copied files ... not sure
> how often that changes.

Nor I. Anyway, feel free to propose an actual patch.