Re: [PATCH v2 2/2] module: Add module name to modinfo

From: Jon Masters
Date: Tue Apr 25 2017 - 03:04:20 EST


Nevermind. Missread the patch as doing something different on first pass.

--
Computer Architect | Sent from my 64-bit #ARM Powered phone

> On Apr 25, 2017, at 03:00, Jon Masters <jcm@xxxxxxxxxxxxxx> wrote:
>
>> On 04/21/2017 06:35 PM, Kees Cook wrote:
>>
>> Accessing the mod structure (e.g. for mod->name) prior to having completed
>> check_modstruct_version() can result in writing garbage to the error logs
>> if the layout of the mod structure loaded from disk doesn't match the
>> running kernel's mod structure layout. This kind of mismatch will become
>> much more likely if a kernel is built with different randomization seed
>> for the struct layout randomization plugin.
>>
>> Instead, add and use a new modinfo string for logging the module name.
>
> +Lucas - probably something that the modinfo kmod utility should track.
>
> Jon.
>