Re: [PATCH 3/4] pinctrl: stm32: Implement .get_direction gpio_chip callback

[Alexandre Torgue]

Hi Linus,

On 04/24/2017 02:37 PM, Linus Walleij wrote:
> On Fri, Apr 7, 2017 at 5:10 PM, Alexandre TORGUE
> <alexandre.torgue@xxxxxx> wrote:
>
> > Add .get_direction() gpiochip callback in STM32 pinctrl driver.
> >
> > Signed-off-by: Alexandre TORGUE <alexandre.torgue@xxxxxx>
>
> (...)
> > +#include <linux/gpio.h>
>
> No this is wrong, drivers should never include this file.
> It is a deprecated consumer header.
>
> > +       if ((alt == 0) && (mode == 0))
> > +               ret = GPIOF_DIR_IN;
> > +       else if ((alt == 0) && (mode == 1))
> > +               ret = GPIOF_DIR_OUT;
>
> Just return 0 or 1, that is the driver-internal API.

Ok. I will fix it in V2.

Thanks
Alex

> Yours,
> Linus Walleij